From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Tue, 5 Feb 2019 06:42:50 +0000 (+0100)
Subject: nbd: remove stack allocations
X-Git-Tag: lxc-3.2.0~164^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9371d3f2b6fa6b67a37616c6ac07bafcae7952b8;p=thirdparty%2Flxc.git

nbd: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---

diff --git a/src/lxc/storage/nbd.c b/src/lxc/storage/nbd.c
index 2fae1fdb2..8b19d63ac 100644
--- a/src/lxc/storage/nbd.c
+++ b/src/lxc/storage/nbd.c
@@ -35,6 +35,7 @@
 
 #include "config.h"
 #include "log.h"
+#include "memory_utils.h"
 #include "nbd.h"
 #include "storage.h"
 #include "storage_utils.h"
@@ -61,14 +62,11 @@ static bool wait_for_partition(const char *path);
 
 bool attach_nbd(char *src, struct lxc_conf *conf)
 {
-	char *orig, *p, path[50];
+	__do_free char *orig;
+	char *p, path[50];
 	int i = 0;
-	size_t len;
-
-	len = strlen(src);
-	orig = alloca(len + 1);
-	(void)strlcpy(orig, src, len + 1);
 
+	orig = must_copy_string(src);
 	/* if path is followed by a partition, drop that for now */
 	p = strchr(orig, ':');
 	if (p)