From: Evan Hunt <each@isc.org>
Date: Wed, 13 Jul 2022 23:15:53 +0000 (-0700)
Subject: check putstr return values
X-Git-Tag: v9.19.4~28^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9372baac271fb410f351db25d85c120dff7b9f46;p=thirdparty%2Fbind9.git

check putstr return values

The calls to putstr() in named_server_fetchlimit() were not checked
for failure.
---

diff --git a/bin/named/server.c b/bin/named/server.c
index fadab6ece27..b49b09d1dcd 100644
--- a/bin/named/server.c
+++ b/bin/named/server.c
@@ -16640,10 +16640,10 @@ named_server_fetchlimit(named_server_t *server, isc_lex_t *lex,
 		}
 
 		if (!first) {
-			putstr(text, "\n");
+			CHECK(putstr(text, "\n"));
 		}
-		putstr(text, "Rate limited servers, view ");
-		putstr(text, view->name);
+		CHECK(putstr(text, "Rate limited servers, view "));
+		CHECK(putstr(text, view->name));
 
 		dns_adb_getquota(view->adb, &val, NULL, NULL, NULL, NULL);
 		s = snprintf(tbuf, sizeof(tbuf),
@@ -16652,26 +16652,26 @@ named_server_fetchlimit(named_server_t *server, isc_lex_t *lex,
 			return (ISC_R_NOSPACE);
 		}
 		first = false;
-		putstr(text, tbuf);
+		CHECK(putstr(text, tbuf));
 		used = isc_buffer_usedlength(*text);
 		CHECK(dns_adb_dumpquota(view->adb, text));
 		if (used == isc_buffer_usedlength(*text)) {
-			putstr(text, "\n  None.");
+			CHECK(putstr(text, "\n  None."));
 		}
 
-		putstr(text, "\nRate limited servers, view ");
-		putstr(text, view->name);
+		CHECK(putstr(text, "\nRate limited servers, view "));
+		CHECK(putstr(text, view->name));
 		val = dns_resolver_getfetchesperzone(view->resolver);
 		s = snprintf(tbuf, sizeof(tbuf),
 			     " (fetches-per-zone %u):", val);
 		if (s < 0 || (unsigned)s > sizeof(tbuf)) {
 			return (ISC_R_NOSPACE);
 		}
-		putstr(text, tbuf);
+		CHECK(putstr(text, tbuf));
 		used = isc_buffer_usedlength(*text);
 		CHECK(dns_resolver_dumpquota(view->resolver, text));
 		if (used == isc_buffer_usedlength(*text)) {
-			putstr(text, "\n  None.");
+			CHECK(putstr(text, "\n  None."));
 		}
 	}