From: Andrew Bartlett <abartlet@samba.org>
Date: Tue, 9 Sep 2008 06:18:27 +0000 (+1000)
Subject: Fix bug #5713 by correcting the generated schema.
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=937b466266256d26d02cf8d48e72a26272fe8627;p=thirdparty%2Fsamba.git

Fix bug #5713 by correcting the generated schema.

This bug is entitled 'Schema patch breaks interoperability with
Microsoft MMC consoles.', and it does so very spectacularly.

The issue is that we would include an entry:
objectClasses: ( 2.5.6.0 NAME 'top' SUP top ABSTRACT..

The MMC Active Directory Users and Computers snap in presumably
objected to the 'loop' this would present. The fixed entry is:

objectClasses: ( 2.5.6.0 NAME 'top' ABSTRACT

Thanks to Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de> for his
persistance in getting me to look at this.

Andrew Bartlett
---

diff --git a/source/dsdb/schema/schema_description.c b/source/dsdb/schema/schema_description.c
index 9d93af9260a..d780fcf34f8 100644
--- a/source/dsdb/schema/schema_description.c
+++ b/source/dsdb/schema/schema_description.c
@@ -182,7 +182,7 @@ char *schema_class_description(TALLOC_CTX *mem_ctx,
 		IF_NULL_FAIL_RET(schema_entry);
 	}
 
-	if (subClassOf) {
+	if (subClassOf && strcasecmp(subClassOf, name) == 0) {
 		schema_entry = talloc_asprintf_append(schema_entry, 
 						      "SUP %s%s", subClassOf, seperator);
 		IF_NULL_FAIL_RET(schema_entry);