From: Douglas Bagnall Date: Wed, 13 Apr 2022 23:40:43 +0000 (+1200) Subject: torture/bind_dlz: return the right kind of failure X-Git-Tag: tevent-0.13.0~378 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=937c2cd38a6365924e0eaaa34b60815eced6126c;p=thirdparty%2Fsamba.git torture/bind_dlz: return the right kind of failure torture_fail() is a macro that returns false, which evaluates to ISC_R_SUCCESS in int context. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15040 Signed-off-by: Douglas Bagnall Reviewed-by: Andrew Bartlett --- diff --git a/source4/torture/dns/dlz_bind9.c b/source4/torture/dns/dlz_bind9.c index 6ace3384964..de6bd57fd5c 100644 --- a/source4/torture/dns/dlz_bind9.c +++ b/source4/torture/dns/dlz_bind9.c @@ -113,7 +113,7 @@ static isc_result_t dlz_bind9_writeable_zone_hook(dns_view_t *view, NULL }; if (ret != LDB_SUCCESS) { - torture_fail(tctx, "Failed to connect to samdb"); + torture_comment(tctx, "Failed to connect to samdb"); return ISC_R_FAILURE; } @@ -121,7 +121,10 @@ static isc_result_t dlz_bind9_writeable_zone_hook(dns_view_t *view, LDB_SCOPE_SUBTREE, attrs, DSDB_SEARCH_SEARCH_ALL_PARTITIONS, "(&(objectClass=dnsZone)(name=%s))", zone_name); if (ret != LDB_SUCCESS) { - torture_fail(tctx, talloc_asprintf(tctx, "Failed to search for %s: %s", zone_name, ldb_errstring(samdb))); + torture_comment(tctx, + "Failed to search for %s: %s", + zone_name, + ldb_errstring(samdb)); return ISC_R_FAILURE; } talloc_free(msg);