From: Koosha Khajeh Moogahi <koosha.khajeh@gmail.com>
Date: Fri, 12 Oct 2012 17:51:50 +0000 (+0200)
Subject: Bug 793826: Prevent private web service methods from being called
X-Git-Tag: bugzilla-4.2.4~21
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=938692bf09df0bce9dae7be72925bf2f1eb75dfe;p=thirdparty%2Fbugzilla.git

Bug 793826: Prevent private web service methods from being called
r=dkl a=LpSolit
---

diff --git a/Bugzilla/WebService/Server.pm b/Bugzilla/WebService/Server.pm
index feb80e9d02..206f0c657d 100644
--- a/Bugzilla/WebService/Server.pm
+++ b/Bugzilla/WebService/Server.pm
@@ -25,7 +25,9 @@ use Scalar::Util qw(blessed);
 
 sub handle_login {
     my ($self, $class, $method, $full_method) = @_;
-    ThrowCodeError('unknown_method', {method => $full_method}) if !$class;
+    # Throw error if the supplied class does not exist or the method is private
+    ThrowCodeError('unknown_method', {method => $full_method}) if (!$class or $method =~ /^_/);
+
     eval "require $class";
     ThrowCodeError('unknown_method', {method => $full_method}) if $@;
     return if ($class->login_exempt($method)