From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Mon, 6 Jun 2022 14:58:59 +0000 (-0400)
Subject: run test_update_rowcount_return_defaults only w/ returning
X-Git-Tag: rel_2_0_0b1~263
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=938c5d1033085289b4cbbd4b9229eaa3ad90b66d;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

run test_update_rowcount_return_defaults only w/ returning

sane_rowcount_w_returning asserts failure, which will only
occur here if the DBAPI actually uses RETURNING.

as SQLite conditionally supports RETURNING which breaks
rowcount support only if present, limit this test to that
case.

Additionally, newer pysqlites will likely fix the issue so
we will probably want to put a sqlite3_version check as well
once that fix is released.

Change-Id: I065aa181eb48363c1024550ae3622486ae0b4a6e
---

diff --git a/lib/sqlalchemy/testing/suite/test_rowcount.py b/lib/sqlalchemy/testing/suite/test_rowcount.py
index d1bf9ae154..b7d4b7452f 100644
--- a/lib/sqlalchemy/testing/suite/test_rowcount.py
+++ b/lib/sqlalchemy/testing/suite/test_rowcount.py
@@ -88,6 +88,7 @@ class RowCountTest(fixtures.TablesTest):
         )
         eq_(r.rowcount, 3)
 
+    @testing.requires.update_returning
     @testing.requires.sane_rowcount_w_returning
     def test_update_rowcount_return_defaults(self, connection):
         employees_table = self.tables.employees