From: Alan T. DeKok <aland@freeradius.org>
Date: Tue, 3 May 2011 07:23:41 +0000 (+0200)
Subject: Don't decode attributes if there's no secret
X-Git-Tag: release_2_1_11~48
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=93a7e7eed6b13bd0076710e7c93d3ea60193031d;p=thirdparty%2Ffreeradius-server.git

Don't decode attributes if there's no secret

This is really a bug in the caller, but it's a reasonable
change to make.
---

diff --git a/src/lib/radius.c b/src/lib/radius.c
index a3fbac7da2e..ef3abbdbdf2 100644
--- a/src/lib/radius.c
+++ b/src/lib/radius.c
@@ -2249,7 +2249,7 @@ static VALUE_PAIR *data2vp(const RADIUS_PACKET *packet,
 	/*
 	 *	Decrypt the attribute.
 	 */
-	switch (vp->flags.encrypt) {
+	if (secret) switch (vp->flags.encrypt) {
 		/*
 		 *  User-Password
 		 */