From: David Vašek <david.vasek@nic.cz>
Date: Thu, 3 Dec 2020 13:23:12 +0000 (+0100)
Subject: ctl: try to report the error in zone_backup_cmd()
X-Git-Tag: v3.1.0~232^2~10
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=93ab58428c719df32222c7ec00ccdef1c574b6e1;p=thirdparty%2Fknot-dns.git

ctl: try to report the error in zone_backup_cmd()
---

diff --git a/src/knot/ctl/commands.c b/src/knot/ctl/commands.c
index 482fd4191a..9d2c0ea714 100644
--- a/src/knot/ctl/commands.c
+++ b/src/knot/ctl/commands.c
@@ -455,13 +455,13 @@ static int zone_backup_cmd(zone_t *zone, ctl_args_t *args)
 	ctx->readers++;
 	pthread_mutex_unlock(&ctx->readers_mutex);
 
-	(void)schedule_trigger(zone, args, ZONE_EVENT_BACKUP, true);
+	int ret = schedule_trigger(zone, args, ZONE_EVENT_BACKUP, true);
 
-	if (ctx->backup_global) {
-		return KNOT_EOK;
-	} else {
-		return global_backup(ctx, zone->catalog, zone->name);
+	if (ret == KNOT_EOK && !ctx->backup_global) {
+		ret = global_backup(ctx, zone->catalog, zone->name);
 	}
+
+	return ret;
 }
 
 static int zone_sign(zone_t *zone, ctl_args_t *args)