From: Vincent Vanlaer Date: Mon, 19 Feb 2024 22:24:02 +0000 (+0100) Subject: daemon: fix wrong request count for sparse stream X-Git-Tag: v10.1.0-rc1~24 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=93d67c58c2fc6a9326d5ea6a77304626a1d37394;p=thirdparty%2Flibvirt.git daemon: fix wrong request count for sparse stream Similar to when actual data is being written to the stream, it is necessary to acknowledge handling of the client request when a hole is encountered. This is done later in daemonStreamHandleWrite by sending a fake zero-length reply if the status variable is set to VIR_STREAM_CONTINUE. It seems that setting status from the message header was missed for holes in the introduction of the sparse stream feature. Signed-off-by: Vincent Vanlaer Reviewed-by: Michal Privoznik --- diff --git a/src/remote/remote_daemon_stream.c b/src/remote/remote_daemon_stream.c index 1a89ff822c..453728a66b 100644 --- a/src/remote/remote_daemon_stream.c +++ b/src/remote/remote_daemon_stream.c @@ -747,6 +747,7 @@ daemonStreamHandleWrite(virNetServerClient *client, * Otherwise just carry on with processing stream * data. */ ret = daemonStreamHandleHole(client, stream, msg); + status = msg->header.status; } else if (msg->header.type == VIR_NET_STREAM) { status = msg->header.status; switch (status) {