From: Volker Lendecke <vl@samba.org>
Date: Sat, 13 Jun 2026 09:20:32 +0000 (+0200)
Subject: net: Remove unused "struct dns_connection *conn"
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=93eefb4906e691ddbb22393b089bf6535e98fb03;p=thirdparty%2Fsamba.git

net: Remove unused "struct dns_connection *conn"

With the conversion to PIDL-based dns client routines we don't need it
anymore.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/source3/utils/net_dns.c b/source3/utils/net_dns.c
index 1a8d3e8877f..21cd0eb406f 100644
--- a/source3/utils/net_dns.c
+++ b/source3/utils/net_dns.c
@@ -108,7 +108,6 @@ DNS_ERROR DoDNSUpdate(const char *pszServerAddress,
 		      bool remove_host)
 {
 	DNS_ERROR err;
-	struct dns_connection *conn;
 	TALLOC_CTX *mem_ctx;
 	struct samba_sockaddr sslist[num_addrs];
 	size_t i;
@@ -133,11 +132,6 @@ DNS_ERROR DoDNSUpdate(const char *pszServerAddress,
 		sslist[i] = (struct samba_sockaddr){.u.ss = _sslist[i]};
 	}
 
-	err = dns_open_connection(pszServerAddress, DNS_TCP, mem_ctx, &conn);
-	if (!ERR_DNS_IS_OK(err)) {
-		goto error;
-	}
-
 	if (flags & DNS_UPDATE_PROBE) {
 
 		struct dns_name_packet *probe = NULL, *reply = NULL;