From: Mark Andrews <marka@isc.org>
Date: Tue, 8 Nov 2022 13:06:52 +0000 (+0000)
Subject: Add RUNTIME_CHECK for dns_rdata_tostruct
X-Git-Tag: v9.19.8~20^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=94008863decf59132d1f9e4df4172b1d0ab57675;p=thirdparty%2Fbind9.git

Add RUNTIME_CHECK for dns_rdata_tostruct
---

diff --git a/lib/dns/rdata.c b/lib/dns/rdata.c
index 13cccae9f62..f7f9a9deb58 100644
--- a/lib/dns/rdata.c
+++ b/lib/dns/rdata.c
@@ -2433,12 +2433,14 @@ svcb_hashttp(isc_textregion_t *alpn) {
 isc_result_t
 dns_rdata_checksvcb(const dns_name_t *owner, const dns_rdata_t *rdata) {
 	dns_rdata_in_svcb_t svcb;
+	isc_result_t result;
 
 	REQUIRE(owner != NULL);
 	REQUIRE(rdata != NULL);
 	REQUIRE(DNS_RDATA_VALIDFLAGS(rdata));
 
-	dns_rdata_tostruct(rdata, &svcb, NULL);
+	result = dns_rdata_tostruct(rdata, &svcb, NULL);
+	RUNTIME_CHECK(result == ISC_R_SUCCESS);
 
 	/*
 	 * Check that Alias Mode records don't have SvcParamKeys.