From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Tue, 5 Jan 2021 08:54:18 +0000 (+0100)
Subject: rec: Remove unneeded 'static'
X-Git-Tag: rec-4.4.3~4^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9458b20447fdfaee937a4b741c951e969b0ff74d;p=thirdparty%2Fpdns.git

rec: Remove unneeded 'static'

(cherry picked from commit 3eff7a0d105c6fa6342a82a217e1f96217824dbf)
---

diff --git a/pdns/recursordist/test-syncres_cc.cc b/pdns/recursordist/test-syncres_cc.cc
index 8c8de61843..f9e10d4b93 100644
--- a/pdns/recursordist/test-syncres_cc.cc
+++ b/pdns/recursordist/test-syncres_cc.cc
@@ -72,13 +72,13 @@ bool primeHints(void)
     arr.d_content = std::make_shared<ARecordContent>(ComboAddress(rootIps4[c - 'a']));
     vector<DNSRecord> aset;
     aset.push_back(arr);
-          s_RC->replace(time(nullptr), DNSName(templ), QType(QType::A), aset, vector<std::shared_ptr<RRSIGRecordContent>>(), vector<std::shared_ptr<DNSRecord>>(), true, g_rootdnsname); // auth, nuke it all
+    s_RC->replace(time(nullptr), DNSName(templ), QType(QType::A), aset, vector<std::shared_ptr<RRSIGRecordContent>>(), vector<std::shared_ptr<DNSRecord>>(), true, g_rootdnsname); // auth, nuke it all
     if (rootIps6[c - 'a'] != NULL) {
       aaaarr.d_content = std::make_shared<AAAARecordContent>(ComboAddress(rootIps6[c - 'a']));
 
       vector<DNSRecord> aaaaset;
       aaaaset.push_back(aaaarr);
-          s_RC->replace(time(nullptr), DNSName(templ), QType(QType::AAAA), aaaaset, vector<std::shared_ptr<RRSIGRecordContent>>(), vector<std::shared_ptr<DNSRecord>>(), true, g_rootdnsname);
+      s_RC->replace(time(nullptr), DNSName(templ), QType(QType::AAAA), aaaaset, vector<std::shared_ptr<RRSIGRecordContent>>(), vector<std::shared_ptr<DNSRecord>>(), true, g_rootdnsname);
     }
 
     nsset.push_back(nsrr);
diff --git a/pdns/reczones.cc b/pdns/reczones.cc
index 65f641f597..992958b1d1 100644
--- a/pdns/reczones.cc
+++ b/pdns/reczones.cc
@@ -46,7 +46,7 @@ bool primeHints(void)
 {
   // prime root cache
   const vState validationState = vState::Insecure;
-  static const ComboAddress from("255.255.255.255");
+  const ComboAddress from("255.255.255.255");
   vector<DNSRecord> nsset;
   t_rootNSZones.clear();