From: Thomas Markwalder <tmark@isc.org>
Date: Fri, 6 Jul 2018 18:48:41 +0000 (-0400)
Subject: [5680] Added a couple more unit test cases
X-Git-Tag: ha_phase2~38
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=94678697e6f1a7906d3dfbd0206502fee5aa036c;p=thirdparty%2Fkea.git

[5680] Added a couple more unit test cases
---

diff --git a/src/lib/util/tests/strutil_unittest.cc b/src/lib/util/tests/strutil_unittest.cc
index c84537120c..799f91273a 100644
--- a/src/lib/util/tests/strutil_unittest.cc
+++ b/src/lib/util/tests/strutil_unittest.cc
@@ -471,6 +471,14 @@ TEST(StringUtilTest, sanitizeString) {
     ASSERT_THROW (sanitized = sanitizeString("just a string", "[bogus-regex",""),
                   BadValue);
 
+    // List of invalid chars should work: (b,c,2 are invalid)
+    ASSERT_NO_THROW (sanitized = sanitizeString("abc.123", "[b-c2]","*"));
+    EXPECT_EQ(sanitized, "a**.1*3");
+
+    // Inverted list for valid chars should work too: (b,c,2 are valid)
+    ASSERT_NO_THROW (sanitized = sanitizeString("abc.123", "[^b-c2]","*"));
+    EXPECT_EQ(sanitized, "*bc**2*");
+
     // A string of all valid chars should return an identical string.
     ASSERT_NO_THROW (sanitized = sanitizeString("-_A--B__Cabc34567_-", "[^A-Ca-c3-7_-]","x"));
     EXPECT_EQ(sanitized, "-_A--B__Cabc34567_-");
@@ -494,6 +502,10 @@ TEST(StringUtilTest, sanitizeString) {
     // Replacing with a string should work.
     ASSERT_NO_THROW (sanitized = sanitizeString("%%A%%B%%C%%", "[^A-Za-z0-9_]","xyz"));
     EXPECT_EQ(sanitized, "xyzxyzAxyzxyzBxyzxyzCxyzxyz");
+
+    // Dots as valid chars work.
+    ASSERT_NO_THROW (sanitized = sanitizeString("abc.123", "[^A-Za-z0-9_.]","*"));
+    EXPECT_EQ(sanitized, "abc.123");
 }
 
 } // end of anonymous namespace