From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Fri, 25 Aug 2023 01:57:09 +0000 (+1200)
Subject: gp: Don’t shadow imports
X-Git-Tag: tevent-0.16.0~768
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=94afa3b194607d389986f2504c15c02578aa8ada;p=thirdparty%2Fsamba.git

gp: Don’t shadow imports

Rename a variable that shadows an import of ‘gp_ext’.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/python/samba/gp/gp_ext_loader.py b/python/samba/gp/gp_ext_loader.py
index bd702de55a5..705b9734a74 100644
--- a/python/samba/gp/gp_ext_loader.py
+++ b/python/samba/gp/gp_ext_loader.py
@@ -45,15 +45,15 @@ def get_gp_client_side_extensions(smb_conf):
     user_exts = []
     machine_exts = []
     gp_exts = list_gp_extensions(smb_conf)
-    for gp_ext in gp_exts.values():
-        module = import_file(gp_ext['ProcessGroupPolicy'], gp_ext['DllName'])
-        ext = get_gp_ext_from_module(gp_ext['ProcessGroupPolicy'], module)
-        if ext and gp_ext['MachinePolicy']:
+    for gp_extension in gp_exts.values():
+        module = import_file(gp_extension['ProcessGroupPolicy'], gp_extension['DllName'])
+        ext = get_gp_ext_from_module(gp_extension['ProcessGroupPolicy'], module)
+        if ext and gp_extension['MachinePolicy']:
             machine_exts.append(ext)
             log.info('Loaded machine extension from %s: %s'
-                     % (gp_ext['DllName'], ext.__name__))
-        if ext and gp_ext['UserPolicy']:
+                     % (gp_extension['DllName'], ext.__name__))
+        if ext and gp_extension['UserPolicy']:
             user_exts.append(ext)
             log.info('Loaded user extension from %s: %s'
-                     % (gp_ext['DllName'], ext.__name__))
+                     % (gp_extension['DllName'], ext.__name__))
     return (machine_exts, user_exts)