From: Victor Julien <vjulien@oisf.net>
Date: Wed, 27 Apr 2022 09:38:37 +0000 (+0200)
Subject: ja3: fix minor format string warning
X-Git-Tag: suricata-5.0.10~57
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=94b0f15506a404f6eb04a2316beae9bbcacc286a;p=thirdparty%2Fsuricata.git

ja3: fix minor format string warning

cppcheck:

src/util-ja3.c:197:28: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
        (*buffer)->used += snprintf((*buffer)->data, (*buffer)->size, "%d",
                           ^
src/util-ja3.c:201:28: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
        (*buffer)->used += snprintf((*buffer)->data + (*buffer)->used,
                           ^

Bug: #5291.
(cherry picked from commit 1e13f7278585555623ff0be2d3a98476617b1219)
---

diff --git a/src/util-ja3.c b/src/util-ja3.c
index c937920009..564e919b5d 100644
--- a/src/util-ja3.c
+++ b/src/util-ja3.c
@@ -194,13 +194,11 @@ int Ja3BufferAddValue(JA3Buffer **buffer, uint32_t value)
     }
 
     if ((*buffer)->used == 0) {
-        (*buffer)->used += snprintf((*buffer)->data, (*buffer)->size, "%d",
-                                    value);
+        (*buffer)->used += snprintf((*buffer)->data, (*buffer)->size, "%u", value);
     }
     else {
-        (*buffer)->used += snprintf((*buffer)->data + (*buffer)->used,
-                                    (*buffer)->size - (*buffer)->used, "-%d",
-                                    value);
+        (*buffer)->used += snprintf(
+                (*buffer)->data + (*buffer)->used, (*buffer)->size - (*buffer)->used, "-%u", value);
     }
 
     return 0;