From: Alan T. DeKok <aland@freeradius.org>
Date: Wed, 9 Jan 2019 17:23:54 +0000 (-0500)
Subject: remove redundant check
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=94d8b5da31b6916e26cff35c0dd5abac8fc39cd6;p=thirdparty%2Ffreeradius-server.git

remove redundant check
---

diff --git a/src/bin/radict.c b/src/bin/radict.c
index 79ef1495234..6149e6b4b99 100644
--- a/src/bin/radict.c
+++ b/src/bin/radict.c
@@ -266,7 +266,7 @@ int main(int argc, char *argv[])
 			fr_dict_export(&count, &low, &high, *dict_p);
 			DEBUG2("Attribute count %" PRIu64, count);
 			DEBUG2("Memory allocd %zu (bytes)", talloc_total_size(*dict_p));
-			DEBUG2("Memory spread %zu (bytes)", (high - low));
+			DEBUG2("Memory spread %zu (bytes)", (size_t) (high - low));
 		} while (++dict_p < dict_end);
 	}
 
diff --git a/src/bin/radsniff.c b/src/bin/radsniff.c
index 137a4d8d03d..a021d531fd0 100644
--- a/src/bin/radsniff.c
+++ b/src/bin/radsniff.c
@@ -208,7 +208,7 @@ static void rs_time_print(char *out, size_t len, struct timeval const *t)
 
 	if (usec) {
 		while (usec < 100000) usec *= 10;
-		snprintf(out + ret, len - ret, ".%i", usec);
+		snprintf(out + ret, len - ret, ".%u", usec);
 	} else {
 		snprintf(out + ret, len - ret, ".000000");
 	}
diff --git a/src/bin/unit_test_attribute.c b/src/bin/unit_test_attribute.c
index e929c074d0d..95f51ef133b 100644
--- a/src/bin/unit_test_attribute.c
+++ b/src/bin/unit_test_attribute.c
@@ -707,7 +707,7 @@ static void command_add(TALLOC_CTX *ctx, char *input, char *output, size_t outle
 	p++;
 
 
-	if (input) parent = talloc_strdup(ctx, input);
+	parent = talloc_strdup(ctx, input);
 
 	/*
 	 *	Set the name and try to find the syntax.