From: Stefan Metzmacher Date: Wed, 19 Feb 2025 12:23:55 +0000 (+0100) Subject: s4:kdc: move user_info_dc_shallow_copy variable in samba_kdc_update_pac() X-Git-Tag: tevent-0.17.0~654 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=94e77288dc5ab83e38a71e7c26a3555724db4c6e;p=thirdparty%2Fsamba.git s4:kdc: move user_info_dc_shallow_copy variable in samba_kdc_update_pac() This is only needed as tmp variable in the if block... Signed-off-by: Stefan Metzmacher Reviewed-by: Ralph Boehme --- diff --git a/source4/kdc/pac-glue.c b/source4/kdc/pac-glue.c index e336a58073e..cfe3d285ab2 100644 --- a/source4/kdc/pac-glue.c +++ b/source4/kdc/pac-glue.c @@ -2660,7 +2660,6 @@ krb5_error_code samba_kdc_update_pac(TALLOC_CTX *mem_ctx, bool server_restrictions_present = false; struct pac_blobs *pac_blobs = NULL; const struct auth_user_info_dc *user_info_dc_const = NULL; - struct auth_user_info_dc *user_info_dc_shallow_copy = NULL; const struct auth_user_info_dc *device_info_dc = NULL; const struct PAC_DOMAIN_GROUP_MEMBERSHIP *_resource_groups = NULL; enum auth_group_inclusion group_inclusion; @@ -2859,6 +2858,8 @@ krb5_error_code samba_kdc_update_pac(TALLOC_CTX *mem_ctx, } if (compounded_auth) { + struct auth_user_info_dc *user_info_dc_shallow_copy = NULL; + /* Make a shallow copy of the user_info_dc structure. */ nt_status = authsam_shallow_copy_user_info_dc(tmp_ctx, user_info_dc_const,