From: Jürg Billeter <j@bitron.ch>
Date: Fri, 9 Jan 2009 22:53:11 +0000 (+0000)
Subject: Fix memory leak when retrieving values from property getters returning
X-Git-Tag: VALA_0_5_5~11
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=94eb2ae7a0fc4fe7fdf6652bdc866c2cb6fdbfe8;p=thirdparty%2Fvala.git

Fix memory leak when retrieving values from property getters returning

2009-01-09  Jürg Billeter  <j@bitron.ch>

	* vala/valasemanticanalyzer.vala:

	Fix memory leak when retrieving values from property getters
	returning owned values, fixes bug 564081

svn path=/trunk/; revision=2314
---

diff --git a/ChangeLog b/ChangeLog
index e3cdd1a96..dfe6bdcc3 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2009-01-09  Jürg Billeter  <j@bitron.ch>
+
+	* vala/valasemanticanalyzer.vala:
+
+	Fix memory leak when retrieving values from property getters
+	returning owned values, fixes bug 564081
+
 2009-01-09  Jürg Billeter  <j@bitron.ch>
 
 	* gobject/valaccodememberaccessmodule.vala:
diff --git a/vala/valasemanticanalyzer.vala b/vala/valasemanticanalyzer.vala
index f6e8588e7..bd1d25a0f 100644
--- a/vala/valasemanticanalyzer.vala
+++ b/vala/valasemanticanalyzer.vala
@@ -1,6 +1,7 @@
 /* valasemanticanalyzer.vala
  *
- * Copyright (C) 2006-2009  Jürg Billeter, Raffaele Sandrini
+ * Copyright (C) 2006-2009  Jürg Billeter
+ * Copyright (C) 2006-2008  Raffaele Sandrini
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
@@ -163,7 +164,10 @@ public class Vala.SemanticAnalyzer : CodeVisitor {
 			var prop = (Property) sym;
 			if (prop.property_type != null) {
 				var type = prop.property_type.copy ();
-				type.value_owned = false;
+				if (lvalue) {
+					// setters never take ownership
+					type.value_owned = false;
+				}
 				return type;
 			}
 		} else if (sym is FormalParameter) {