From: Ilya Dryomov Date: Wed, 13 Nov 2019 11:07:15 +0000 (+0100) Subject: rbd: silence bogus uninitialized warning in rbd_object_map_update_finish() X-Git-Tag: v5.3.16~80 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=94fb895537c41354da885bb3de2aa75d1e2feb72;p=thirdparty%2Fkernel%2Fstable.git rbd: silence bogus uninitialized warning in rbd_object_map_update_finish() [ Upstream commit 633739b2fedb6617d782ca252797b7a8ad754347 ] Some versions of gcc (so far 6.3 and 7.4) throw a warning: drivers/block/rbd.c: In function 'rbd_object_map_callback': drivers/block/rbd.c:2124:21: warning: 'current_state' may be used uninitialized in this function [-Wmaybe-uninitialized] (current_state == OBJECT_EXISTS && state == OBJECT_EXISTS_CLEAN)) drivers/block/rbd.c:2092:23: note: 'current_state' was declared here u8 state, new_state, current_state; ^~~~~~~~~~~~~ It's bogus because all current_state accesses are guarded by has_current_state. Reported-by: kbuild test robot Signed-off-by: Ilya Dryomov Reviewed-by: Dongsheng Yang Signed-off-by: Sasha Levin --- diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index c8fb886aebd4e..64e364c4a0fb8 100644 --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c @@ -2089,7 +2089,7 @@ static int rbd_object_map_update_finish(struct rbd_obj_request *obj_req, struct rbd_device *rbd_dev = obj_req->img_request->rbd_dev; struct ceph_osd_data *osd_data; u64 objno; - u8 state, new_state, current_state; + u8 state, new_state, uninitialized_var(current_state); bool has_current_state; void *p;