From: Dan Carpenter Date: Tue, 15 Jul 2025 23:01:39 +0000 (-0500) Subject: spi: stm32-ospi: Fix NULL vs IS_ERR() bug in stm32_ospi_get_resources() X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=951a6d8d41289b86a564ee5563ededa702b62b1b;p=thirdparty%2Fkernel%2Fstable.git spi: stm32-ospi: Fix NULL vs IS_ERR() bug in stm32_ospi_get_resources() This code was changed from using devm_ioremap() which returns NULL to using devm_ioremap_resource() which returns error pointers. Update the error checking to match. Fixes: defe01abfb7f ("spi: stm32-ospi: Use of_reserved_mem_region_to_resource() for "memory-region"") Signed-off-by: Dan Carpenter Link: https://patch.msgid.link/fb2a26a2-119b-4b5a-8d44-b29e2c736081@sabinyo.mountain Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-stm32-ospi.c b/drivers/spi/spi-stm32-ospi.c index 72baa402a2c3a..f36fd36da2692 100644 --- a/drivers/spi/spi-stm32-ospi.c +++ b/drivers/spi/spi-stm32-ospi.c @@ -823,9 +823,9 @@ static int stm32_ospi_get_resources(struct platform_device *pdev) if (!ret) { ospi->mm_size = resource_size(res); ospi->mm_base = devm_ioremap_resource(dev, res); - if (!ospi->mm_base) { + if (IS_ERR(ospi->mm_base)) { dev_err(dev, "unable to map memory region: %pR\n", res); - ret = -ENOMEM; + ret = PTR_ERR(ospi->mm_base); goto err_dma; }