From: James Hogan Date: Tue, 27 Aug 2013 16:48:36 +0000 (+0100) Subject: target-mips: fix get_physical_address() #if 0 build error X-Git-Tag: v1.7.0-rc0~152 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=951fab990db05d47ab9da5e72521e406c73a3eb9;p=thirdparty%2Fqemu.git target-mips: fix get_physical_address() #if 0 build error In get_physical_address() is a qemu_log() call inside an #if 0 block. When enabled the following build error is hit: target-mips/helper.c In function ‘get_physical_address’: target-mips/helper.c:220:13: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 5 has type ‘hwaddr’ [-Werror=format] Fix the *physical (hwaddr) formatting by using "%"HWADDR_PRIx instead of TARGET_FMT_lx. Signed-off-by: James Hogan Cc: Aurelien Jarno Signed-off-by: Yongbok Kim Signed-off-by: Aurelien Jarno --- diff --git a/target-mips/helper.c b/target-mips/helper.c index 6feef7bcd61..33e0e886377 100644 --- a/target-mips/helper.c +++ b/target-mips/helper.c @@ -193,7 +193,7 @@ static int get_physical_address (CPUMIPSState *env, hwaddr *physical, } } #if 0 - qemu_log(TARGET_FMT_lx " %d %d => " TARGET_FMT_lx " %d (%d)\n", + qemu_log(TARGET_FMT_lx " %d %d => %" HWADDR_PRIx " %d (%d)\n", address, rw, access_type, *physical, *prot, ret); #endif