From: Michał Kępień <michal@isc.org>
Date: Mon, 18 Jan 2021 13:57:47 +0000 (+0100)
Subject: Flag trailing dots in commit subject lines
X-Git-Tag: v9.17.10~33^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=953c810f4161f62c36fc463ce973ad8237e74b5b;p=thirdparty%2Fbind9.git

Flag trailing dots in commit subject lines

Make the Danger GitLab CI job fail when the subject line for any commit
belonging to a merge request contains a trailing dot.
---

diff --git a/dangerfile.py b/dangerfile.py
index 7cec7162ccd..ad40478f773 100644
--- a/dangerfile.py
+++ b/dangerfile.py
@@ -43,6 +43,8 @@ target_branch = danger.gitlab.mr.target_branch
 #
 #     * The subject line starts with "fixup!" or "Apply suggestion".
 #
+#     * The subject line contains a trailing dot.
+#
 #     * There is no empty line between the subject line and the log message.
 #
 # - WARN if any of the following is true for any commit on the MR branch:
@@ -70,6 +72,8 @@ for commit in danger.git.commits:
             f'Subject line for commit {commit.sha} is too long: '
             f'```{subject}``` ({len(subject)} > 72 characters).'
         )
+    if subject[-1] == '.':
+        fail(f'Trailing dot found in the subject of commit {commit.sha}.')
     if len(message_lines) > 1 and message_lines[1]:
         fail(f'No empty line after subject for commit {commit.sha}.')
     if (len(message_lines) < 3 and