From: Jo Sutton <josutton@catalyst.net.nz>
Date: Thu, 18 Jul 2024 01:53:09 +0000 (+1200)
Subject: tests/krb5: Remove unneeded machine account creation
X-Git-Tag: tdb-1.4.12~33
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9542c419a07ae03c8de6ae5ebf634f925e9f69ea;p=thirdparty%2Fsamba.git

tests/krb5: Remove unneeded machine account creation

Signed-off-by: Jo Sutton <josutton@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
---

diff --git a/python/samba/tests/krb5/ms_kile_client_principal_lookup_tests.py b/python/samba/tests/krb5/ms_kile_client_principal_lookup_tests.py
index c3d3ca9e130..23a3fce55ed 100755
--- a/python/samba/tests/krb5/ms_kile_client_principal_lookup_tests.py
+++ b/python/samba/tests/krb5/ms_kile_client_principal_lookup_tests.py
@@ -402,7 +402,7 @@ class MS_Kile_Client_Principal_Lookup_Tests(KDCBaseTest):
             This test uses the altsecid, so the AS-REQ should fail.
         """
 
-        # Create user and machine accounts for the test.
+        # Create a user account for the test.
         #
         samdb = self.get_samdb()
         user_name = "mskileusr"
@@ -412,10 +412,6 @@ class MS_Kile_Client_Principal_Lookup_Tests(KDCBaseTest):
         alt_sec = "Kerberos:%s@%s" % (alt_name, realm)
         self.add_attribute(samdb, dn, "altSecurityIdentities", alt_sec)
 
-        mach_name = "mskilemac"
-        (mc, _) = self.create_account(samdb, mach_name,
-                                      account_type=self.AccountType.COMPUTER)
-
         # Do the initial AS-REQ, should get a pre-authentication required
         # response
         etype = (AES256_CTS_HMAC_SHA1_96, ARCFOUR_HMAC_MD5)
@@ -770,7 +766,7 @@ class MS_Kile_Client_Principal_Lookup_Tests(KDCBaseTest):
             This test uses the altsecid, so the AS-REQ should fail.
         """
 
-        # Create user and machine accounts for the test.
+        # Create a user account for the test.
         #
         samdb = self.get_samdb()
         user_name = "mskileusr"
@@ -781,10 +777,6 @@ class MS_Kile_Client_Principal_Lookup_Tests(KDCBaseTest):
         self.add_attribute(samdb, dn, "altSecurityIdentities", alt_sec)
         ename = alt_name + "@" + realm
 
-        mach_name = "mskilemac"
-        (mc, _) = self.create_account(samdb, mach_name,
-                                      account_type=self.AccountType.COMPUTER)
-
         # Do the initial AS-REQ, should get a pre-authentication required
         # response
         etype = (AES256_CTS_HMAC_SHA1_96, ARCFOUR_HMAC_MD5)