From: Bas van Schaik <sjvs@users.noreply.github.com>
Date: Wed, 16 Mar 2016 10:33:51 +0000 (+0000)
Subject: Update pdns/Makefile.am: make curl report error on failure
X-Git-Tag: dnsdist-1.0.0-beta1~94^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=95536d16eb1ec86186fe1a03323aa541423c1391;p=thirdparty%2Fpdns.git

Update pdns/Makefile.am: make curl report error on failure

By default 'curl -s' (for silent) will swallow any errors that occur during the retrieval of the URL. This makes problems rather difficult to debug. The '-S' flag changes this behaviour: "When used with -s it makes curl show an error message if it fails" (from the manpage)
---

diff --git a/pdns/Makefile.am b/pdns/Makefile.am
index cb67d3bb5e..b2ab32b468 100644
--- a/pdns/Makefile.am
+++ b/pdns/Makefile.am
@@ -1115,7 +1115,7 @@ curl_verbose = $(curl_verbose_$(V))
 curl_verbose_ = $(curl_verbose_$(AM_DEFAULT_VERBOSITY))
 curl_verbose_0 = @echo "  CURL    " $@;
 $(srcdir)/effective_tld_names.dat:
-	$(curl_verbose)if ! curl -s https://publicsuffix.org/list/public_suffix_list.dat > $@; then rm -f $@; exit 1; fi
+	$(curl_verbose)if ! curl -s -S https://publicsuffix.org/list/public_suffix_list.dat > $@; then rm -f $@; exit 1; fi
 
 pubsuffix.cc: $(srcdir)/effective_tld_names.dat
 	$(AM_V_GEN)./mkpubsuffixcc