From: Tomi Valkeinen <tomi.valkeinen@ti.com>
Date: Fri, 4 Aug 2017 09:20:03 +0000 (+0300)
Subject: drm/omap: fix memory leak when FB init fails
X-Git-Tag: v4.14-rc1~179^2~26^2~59
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=95552191f0a0c3632808d8883fc05d37a5c2fe14;p=thirdparty%2Fkernel%2Flinux.git

drm/omap: fix memory leak when FB init fails

omap_framebuffer_create() fails to unref all the gem objects if creating
the FB fails, leading to a memory leak.

Fix the loop so that it goes through all the reffed gem objects.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---

diff --git a/drivers/gpu/drm/omapdrm/omap_fb.c b/drivers/gpu/drm/omapdrm/omap_fb.c
index ddf7a457951be..b1a762b70cbf8 100644
--- a/drivers/gpu/drm/omapdrm/omap_fb.c
+++ b/drivers/gpu/drm/omapdrm/omap_fb.c
@@ -379,7 +379,7 @@ struct drm_framebuffer *omap_framebuffer_create(struct drm_device *dev,
 	return fb;
 
 error:
-	while (--i > 0)
+	while (--i >= 0)
 		drm_gem_object_unreference_unlocked(bos[i]);
 
 	return fb;