From: Phil Sutter <phil@nwl.cc>
Date: Fri, 17 Oct 2025 07:29:47 +0000 (+0200)
Subject: netlink: Zero nft_data_linearize objects when populating
X-Git-Tag: v1.1.6~24
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=95618771d5e4c2bd4b0aa1dac458395ddd158f7f;p=thirdparty%2Fnftables.git

netlink: Zero nft_data_linearize objects when populating

Callers of netlink_gen_{key,data}() pass an uninitialized auto-variable,
avoid misinterpreting garbage in fields "left blank".

Signed-off-by: Phil Sutter <phil@nwl.cc>
---

diff --git a/src/netlink.c b/src/netlink.c
index 7882381e..3258f9ab 100644
--- a/src/netlink.c
+++ b/src/netlink.c
@@ -563,6 +563,8 @@ static void netlink_gen_prefix(const struct expr *expr,
 static void netlink_gen_key(const struct expr *expr,
 			    struct nft_data_linearize *data)
 {
+	memset(data, 0, sizeof(*data));
+
 	switch (expr->etype) {
 	case EXPR_VALUE:
 		return netlink_gen_constant_data(expr, data);
@@ -580,6 +582,8 @@ static void netlink_gen_key(const struct expr *expr,
 static void __netlink_gen_data(const struct expr *expr,
 			       struct nft_data_linearize *data, bool expand)
 {
+	memset(data, 0, sizeof(*data));
+
 	switch (expr->etype) {
 	case EXPR_VALUE:
 		return netlink_gen_constant_data(expr, data);