From: Ralph Boehme <slow@samba.org>
Date: Wed, 25 Mar 2020 06:45:43 +0000 (+0100)
Subject: smbd: leave start at NULL, it's not used before being set to smbfname->basename
X-Git-Tag: ldb-2.2.0~1202
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9565c8f99a9db5c033ca7b15f27607dbad12fb21;p=thirdparty%2Fsamba.git

smbd: leave start at NULL, it's not used before being set to smbfname->basename

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/smbd/filename.c b/source3/smbd/filename.c
index 32e5835e676..44ed4e44103 100644
--- a/source3/smbd/filename.c
+++ b/source3/smbd/filename.c
@@ -437,14 +437,7 @@ NTSTATUS unix_convert(TALLOC_CTX *ctx,
 		      uint32_t ucf_flags)
 {
 	struct smb_filename *smb_fname = NULL;
-
-	/*
-	 * This looks strange. But we need "start" initialized to "" here but
-	 * it can't be a const char *, so 'char *start = "";' does not work.
-	 */
-	char cnull = '\0';
-	char *start = &cnull;
-
+	char *start = NULL;
 	char *end;
 	char *dirpath = NULL;
 	char *stream = NULL;