From: Richard Purdie Date: Fri, 15 Jan 2021 15:11:32 +0000 (+0000) Subject: vulkan-samples: Disable PCH for reproducibility X-Git-Tag: lucaceresoli/bug-15201-perf-libtraceevent-missing~9094 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=95686432ecb7e411155563643d59a3d5f683937c;p=thirdparty%2Fopenembedded%2Fopenembedded-core-contrib.git vulkan-samples: Disable PCH for reproducibility We're still seeing reproducibility issues on the autobuilder with this recipe. I was able to make the output "match" by rebuilding the PCH and then rebuilding the binary objects, proving the PCH isn't deterministic. Disable PCH until we can get to the bottom of why that may be. Signed-off-by: Richard Purdie --- diff --git a/meta/recipes-graphics/vulkan/vulkan-samples_git.bb b/meta/recipes-graphics/vulkan/vulkan-samples_git.bb index 447d498fb34..a61dddeb3bb 100644 --- a/meta/recipes-graphics/vulkan/vulkan-samples_git.bb +++ b/meta/recipes-graphics/vulkan/vulkan-samples_git.bb @@ -26,4 +26,8 @@ FILES_${PN} += "${datadir}" # used for logging with LOGE in the code. We need to make this match the value we use # in the debug source remapping from CFLAGS # -EXTRA_OECMAKE = "-DCMAKE_DEBUG_SRCDIR=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR}/" \ No newline at end of file +EXTRA_OECMAKE += "-DCMAKE_DEBUG_SRCDIR=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR}/" +# Binaries built with PCH enabled don't appear reproducible, differing results were seen +# from some builds depending on the point the PCH was compiled. Disable it to be +# deterministic +EXTRA_OECMAKE += "-DCMAKE_DISABLE_PRECOMPILE_HEADERS=ON"