From: Olivier Houchard <ohouchard@haproxy.com>
Date: Fri, 20 Sep 2019 16:08:29 +0000 (+0200)
Subject: MEDIUM: servers: Use LIST_DEL_INIT() instead of LIST_DEL().
X-Git-Tag: v2.1-dev2~52
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9570ecf662db3ebaf2dee02feee84f56b4510ed7;p=thirdparty%2Fhaproxy.git

MEDIUM: servers: Use LIST_DEL_INIT() instead of LIST_DEL().

In srv_add_to_idle_list(), use LIST_DEL_INIT instead of just LIST_DEL.
We're about to add the connection to a mt_list, and MT_LIST_ADD/MT_LIST_ADDQ
will be modified to make sure we're not adding the element if it's already
in a list.
---

diff --git a/include/proto/server.h b/include/proto/server.h
index 5a2fcc9192..0844e8aeb8 100644
--- a/include/proto/server.h
+++ b/include/proto/server.h
@@ -261,7 +261,7 @@ static inline int srv_add_to_idle_list(struct server *srv, struct connection *co
 			_HA_ATOMIC_SUB(&srv->curr_idle_conns, 1);
 			return 0;
 		}
-		LIST_DEL(&conn->list);
+		LIST_DEL_INIT(&conn->list);
 		MT_LIST_ADDQ(&srv->idle_orphan_conns[tid], (struct mt_list *)&conn->list);
 		srv->curr_idle_thr[tid]++;