From: shamoon <4887959+shamoon@users.noreply.github.com>
Date: Wed, 30 Jul 2025 03:31:18 +0000 (-0400)
Subject: Move update length check before operations
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9581cfa1e36ca0ea42e1756e5bc58e60c0dea323;p=thirdparty%2Fpaperless-ngx.git

Move update length check before operations
---

diff --git a/src/documents/bulk_edit.py b/src/documents/bulk_edit.py
index 894d0d4aa..af6be45b6 100644
--- a/src/documents/bulk_edit.py
+++ b/src/documents/bulk_edit.py
@@ -528,6 +528,12 @@ def edit_pdf(
             max_idx = max(op.get("doc", 0) for op in operations)
             pdf_docs = [pikepdf.new() for _ in range(max_idx + 1)]
 
+            if update_document and len(pdf_docs) > 1:
+                logger.error(
+                    "Update requested but multiple output documents specified",
+                )
+                return "ERROR"
+
             for op in operations:
                 dst = pdf_docs[op.get("doc", 0)]
                 page = src.pages[op["page"] - 1]
@@ -536,11 +542,6 @@ def edit_pdf(
                     dst.pages[-1].rotate(op["rotate"], relative=True)
 
         if update_document:
-            if len(pdf_docs) != 1:
-                logger.error(
-                    "Update requested but multiple output documents specified",
-                )
-                return "ERROR"
             pdf = pdf_docs[0]
             pdf.remove_unreferenced_resources()
             pdf.save(doc.source_path)