From: Christopher Faulet <cfaulet@haproxy.com>
Date: Wed, 7 Oct 2020 12:37:00 +0000 (+0200)
Subject: CLEANUP: sock-unix: Remove an unreachable goto clause
X-Git-Tag: v2.3-dev6~84
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9589aa0fe558e2e538af4db60da32299b5b9d710;p=thirdparty%2Fhaproxy.git

CLEANUP: sock-unix: Remove an unreachable goto clause

Coverity reported dead code in sock_unix_bind_receiver() function. A goto clause
is unreachable because of the preceeding if/else block.

This patch should fix the issue #865. No backport needed.
---

diff --git a/src/sock_unix.c b/src/sock_unix.c
index a3056df934..2be8d6bfb7 100644
--- a/src/sock_unix.c
+++ b/src/sock_unix.c
@@ -252,7 +252,6 @@ int sock_unix_bind_receiver(struct receiver *rx, void (*handler)(int fd), char *
 			memprintf(errmsg, "cannot bind UNIX socket (%s)", strerror(errno));
 			goto bind_close_return;
 		}
-		goto err_unlink_temp;
 	}
 
 	/* <uid> and <gid> different of -1 will be used to change the socket owner.