From: Adam Julis <ajulis@redhat.com>
Date: Tue, 6 Aug 2024 07:01:24 +0000 (+0200)
Subject: network: NULL check for "modify" DNS-txt records
X-Git-Tag: v10.7.0-rc1~74
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=959ecee47488cab743b11a9654fabd63c255dd31;p=thirdparty%2Flibvirt.git

network: NULL check for "modify" DNS-txt records

The "modify" command allowed to replace an existing record, now
checks for the NULL string in the new value and throw error if
found.

Resolves: https://gitlab.com/libvirt/libvirt/-/issues/655
Signed-off-by: Adam Julis <ajulis@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index 3af4e1d036..c23b0e4400 100644
--- a/src/conf/network_conf.c
+++ b/src/conf/network_conf.c
@@ -3385,6 +3385,13 @@ virNetworkDefUpdateDNSTxt(virNetworkDef *def,
             goto cleanup;
         }
 
+        if (!txt.value) {
+            virReportError(VIR_ERR_OPERATION_INVALID,
+                           _("missing value of modifying DNS TXT record in network %1$s"),
+                           def->name);
+            goto cleanup;
+        }
+
         VIR_FREE(dns->txts[foundIdx].value);
         dns->txts[foundIdx].value = g_steal_pointer(&txt.value);