From: Willy Tarreau <w@1wt.eu>
Date: Mon, 23 Mar 2020 08:33:32 +0000 (+0100)
Subject: CLEANUP: haproxy/threads: don't check global_tasks_mask twice
X-Git-Tag: v2.2-dev5~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=95abd5be9f9b6480ae102f76cdfffab267cdab22;p=thirdparty%2Fhaproxy.git

CLEANUP: haproxy/threads: don't check global_tasks_mask twice

In run_thread_poll_loop() we test both for (global_tasks_mask & tid_bit)
and thread_has_tasks(), but the former is useless since this test is
already part of the latter.
---

diff --git a/src/haproxy.c b/src/haproxy.c
index ca0ab32700..278476c3e2 100644
--- a/src/haproxy.c
+++ b/src/haproxy.c
@@ -2819,7 +2819,7 @@ void run_poll_loop()
 		else {
 			_HA_ATOMIC_OR(&sleeping_thread_mask, tid_bit);
 			__ha_barrier_atomic_store();
-			if ((global_tasks_mask & tid_bit) || thread_has_tasks()) {
+			if (thread_has_tasks()) {
 				activity[tid].wake_tasks++;
 				_HA_ATOMIC_AND(&sleeping_thread_mask, ~tid_bit);
 			} else