From: Daniel P. Berrange <berrange@redhat.com>
Date: Fri, 13 Jul 2012 11:49:55 +0000 (+0100)
Subject: Don't autostart domains when reloading config
X-Git-Tag: CVE-2012-3445~127
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=95c2c19f06298a6e93849d9a5da8161460c33f43;p=thirdparty%2Flibvirt.git

Don't autostart domains when reloading config

When sending SIGHUP to libvirtd, it will trigger the virStateDriver
reload operation. This is intended to reload the configuration files
for guests. For unknown historical reasons this is also triggering
autostart of all guests. Autostart is generally expected to be
something that happens on OS startup. Starting VMs on SIGHUP will
violate that expectation and potentially cause dangerous scenarios
if the admin has explicitly shutdown a misbehaving VM that has
been marked as autostart

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---

diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
index 2d931db5d4..c341125c93 100644
--- a/src/lxc/lxc_driver.c
+++ b/src/lxc/lxc_driver.c
@@ -2750,8 +2750,6 @@ lxcReload(void) {
                             lxcNotifyLoadDomain, lxc_driver);
     lxcDriverUnlock(lxc_driver);
 
-    lxcAutostartConfigs(lxc_driver);
-
     return 0;
 }
 
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index d3988b8655..46000f4500 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -805,8 +805,6 @@ qemudReload(void) {
                             qemudNotifyLoadDomain, qemu_driver);
     qemuDriverUnlock(qemu_driver);
 
-    qemuAutostartDomains(qemu_driver);
-
     return 0;
 }
 
diff --git a/src/uml/uml_driver.c b/src/uml/uml_driver.c
index 098ee7ba6b..b8d0ab78ef 100644
--- a/src/uml/uml_driver.c
+++ b/src/uml/uml_driver.c
@@ -553,8 +553,6 @@ umlReload(void) {
                             umlNotifyLoadDomain, uml_driver);
     umlDriverUnlock(uml_driver);
 
-    umlAutostartConfigs(uml_driver);
-
     return 0;
 }