From: Christof Schmitt <cs@samba.org>
Date: Thu, 16 Jan 2020 19:15:29 +0000 (-0700)
Subject: vfs_gpfs: Remove function call from "if" statement
X-Git-Tag: ldb-2.1.1~259
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=96252a0ec4c460372f79f8fb31a876ab511c941d;p=thirdparty%2Fsamba.git

vfs_gpfs: Remove function call from "if" statement

Follow the current coding guidelines to first issue the function call
and then check the return code.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/modules/vfs_gpfs.c b/source3/modules/vfs_gpfs.c
index efc00e21f91..240b6839d0b 100644
--- a/source3/modules/vfs_gpfs.c
+++ b/source3/modules/vfs_gpfs.c
@@ -246,8 +246,8 @@ static int vfs_gpfs_setlease(vfs_handle_struct *handle,
 				struct gpfs_config_data,
 				return -1);
 
-	if (linux_set_lease_sighandler(fsp->fh->fd) == -1) {
-		ret = -1;
+	ret = linux_set_lease_sighandler(fsp->fh->fd);
+	if (ret == -1) {
 		goto failure;
 	}