From: Ralph Boehme Date: Sun, 23 Dec 2018 08:23:48 +0000 (+0100) Subject: Revert "pthreadpool: we need to use pthreadpool_tevent_per_thread_cwd() on the caller... X-Git-Tag: talloc-2.1.15~196 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=96332ed100013cb89e92ae3f01a2f46136af3bd2;p=thirdparty%2Fsamba.git Revert "pthreadpool: we need to use pthreadpool_tevent_per_thread_cwd() on the callers pool" This reverts commit ff863f2d98ac5e12073af824b794404c3d7198c5. See the discussion in https://lists.samba.org/archive/samba-technical/2018-December/131731.html for the reasoning behind this revert. Signed-off-by: Ralph Boehme Reviewed-by: Volker Lendecke Reviewed-by: Stefan Metzmacher --- diff --git a/lib/pthreadpool/pthreadpool_tevent.c b/lib/pthreadpool/pthreadpool_tevent.c index b4a9786f231..f88f82d17d8 100644 --- a/lib/pthreadpool/pthreadpool_tevent.c +++ b/lib/pthreadpool/pthreadpool_tevent.c @@ -992,7 +992,6 @@ struct tevent_req *pthreadpool_tevent_job_send( struct pthreadpool_tevent_job_state *state = NULL; struct pthreadpool_tevent_job *job = NULL; int ret; - struct pthreadpool_tevent *caller_pool = pool; struct pthreadpool_tevent_wrapper *wrapper = pool->wrapper.ctx; pthreadpool_tevent_cleanup_orphaned_jobs(); @@ -1038,7 +1037,7 @@ struct tevent_req *pthreadpool_tevent_job_send( return tevent_req_post(req, ev); } PTHREAD_TEVENT_JOB_THREAD_FENCE_INIT(job); - job->per_thread_cwd = pthreadpool_tevent_per_thread_cwd(caller_pool); + job->per_thread_cwd = pthreadpool_tevent_per_thread_cwd(pool); talloc_set_destructor(job, pthreadpool_tevent_job_destructor); DLIST_ADD_END(job->pool->jobs, job); job->state = state;