From: Michael Brown Date: Wed, 22 Mar 2017 12:11:19 +0000 (+0200) Subject: [pixbuf] Avoid potential division by zero X-Git-Tag: v1.20.1~263 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=966a960a8333a9d75da8103cbe5903d380ef7770;p=thirdparty%2Fipxe.git [pixbuf] Avoid potential division by zero Avoid potential division by zero when performing the check against multiplication overflow. (Note that if the width is zero then there can be no overflow anyway, so it is then safe to bypass the check.) Signed-off-by: Michael Brown --- diff --git a/src/core/pixbuf.c b/src/core/pixbuf.c index 4742d285d..641a0fb53 100644 --- a/src/core/pixbuf.c +++ b/src/core/pixbuf.c @@ -68,8 +68,10 @@ struct pixel_buffer * alloc_pixbuf ( unsigned int width, unsigned int height ) { pixbuf->len = ( width * height * sizeof ( uint32_t ) ); /* Check for multiplication overflow */ - if ( ( ( pixbuf->len / sizeof ( uint32_t ) ) / width ) != height ) + if ( ( width != 0 ) && + ( ( pixbuf->len / sizeof ( uint32_t ) ) / width ) != height ) { goto err_overflow; + } /* Allocate pixel data buffer */ pixbuf->data = umalloc ( pixbuf->len );