From: Peter Krempa <pkrempa@redhat.com>
Date: Wed, 4 Aug 2021 09:08:49 +0000 (+0200)
Subject: qemuDomainUSBAddressAddHubs: Refactor cleanup
X-Git-Tag: v7.7.0-rc1~276
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=966ba852b7ed6b593e3f3c5711631329cde05050;p=thirdparty%2Flibvirt.git

qemuDomainUSBAddressAddHubs: Refactor cleanup

'hub' doesn't need to be freed any more because it's always consumed and
NULLed-out by VIR_APPEND element. This also makes the 'ret' variable
obsolete.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c
index 40e84cce9c..392368bd38 100644
--- a/src/qemu/qemu_domain_address.c
+++ b/src/qemu/qemu_domain_address.c
@@ -2942,7 +2942,6 @@ qemuDomainUSBAddressAddHubs(virDomainDef *def)
     virDomainHubDef *hub = NULL;
     size_t available_ports;
     size_t hubs_needed = 0;
-    int ret = -1;
     size_t i;
 
     available_ports = virDomainUSBAddressCountAllPorts(def);
@@ -2972,9 +2971,7 @@ qemuDomainUSBAddressAddHubs(virDomainDef *def)
         VIR_APPEND_ELEMENT(def->hubs, def->nhubs, hub);
     }
 
-    ret = 0;
-    VIR_FREE(hub);
-    return ret;
+    return 0;
 }