From: Miroslav Lichvar <mlichvar@redhat.com>
Date: Tue, 22 Oct 2019 13:25:03 +0000 (+0200)
Subject: logging: make banner printing safer
X-Git-Tag: 4.0-pre1~121
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=96771d68574dfc8da125480838f96c38efd2f0cc;p=thirdparty%2Fchrony.git

logging: make banner printing safer

Don't rely on the buffer filled with '=' characters to be always at
least as long as the log-specific banner string.
---

diff --git a/logging.c b/logging.c
index e12bad7f..1993ab72 100644
--- a/logging.c
+++ b/logging.c
@@ -289,7 +289,7 @@ LOG_FileWrite(LOG_FileID id, const char *format, ...)
     char bannerline[256];
     int i, bannerlen;
 
-    bannerlen = strlen(logfiles[id].banner);
+    bannerlen = MIN(strlen(logfiles[id].banner), sizeof (bannerline) - 1);
 
     for (i = 0; i < bannerlen; i++)
       bannerline[i] = '=';