From: Michael Tremer <michael.tremer@ipfire.org>
Date: Tue, 28 Sep 2021 12:36:25 +0000 (+0000)
Subject: pakfire_package_get_archive: Make return value more native C
X-Git-Tag: 0.9.28~922
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9686a82a9337b7df2d40cc0770a96a01854e4f50;p=pakfire.git

pakfire_package_get_archive: Make return value more native C

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/libpakfire/package.c b/src/libpakfire/package.c
index 7f101987d..e3009c3eb 100644
--- a/src/libpakfire/package.c
+++ b/src/libpakfire/package.c
@@ -1107,7 +1107,7 @@ PAKFIRE_EXPORT char* pakfire_package_dump(struct pakfire_package* pkg, int flags
 }
 
 PAKFIRE_EXPORT struct pakfire_archive* pakfire_package_get_archive(struct pakfire_package* pkg) {
-	struct pakfire_archive* archive;
+	struct pakfire_archive* archive = NULL;
 
 	// Otherwise open the archive from the cache
 	const char* path = pakfire_package_get_path(pkg);
@@ -1116,11 +1116,10 @@ PAKFIRE_EXPORT struct pakfire_archive* pakfire_package_get_archive(struct pakfir
 
 	// Open archive
 	int r = pakfire_archive_open(&archive, pkg->pakfire, path);
+	if (r)
+		return NULL;
 
-	if (r == 0)
-		return archive;
-
-	return NULL;
+	return archive;
 }
 
 static int pakfire_package_fetch_legacy_filelist(struct pakfire_package* pkg, struct pakfire_filelist* filelist) {