From: Kurt Zeilenga <kurt@openldap.org>
Date: Mon, 28 Dec 1998 18:13:18 +0000 (+0000)
Subject: Make LDAP_ALLOW_NULL_SEARCH_BASE the last resort. (from -devel)
X-Git-Tag: OPENLDAP_REL_ENG_1_1_2~16
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=969c89a77bd1c3af43115a7e5659af7c1f6a1226;p=thirdparty%2Fopenldap.git

Make LDAP_ALLOW_NULL_SEARCH_BASE the last resort. (from -devel)
---

diff --git a/servers/slapd/backend.c b/servers/slapd/backend.c
index c2f4656d74..9bc09c94b2 100644
--- a/servers/slapd/backend.c
+++ b/servers/slapd/backend.c
@@ -128,18 +128,6 @@ select_backend( char * dn )
 		for ( j = 0; backends[i].be_suffix != NULL &&
 		    backends[i].be_suffix[j] != NULL; j++ )
 		{
-#ifdef LDAP_ALLOW_NULL_SEARCH_BASE
-			/* Add greg@greg.rim.or.jp
-			 * It's quick hack for cheap client
-			 * Some browser offer a NULL base at ldap_search
-			 */
-			if(dnlen == 0) {
-				Debug( LDAP_DEBUG_TRACE,
-					"select_backend: use default backend\n", 0, 0, 0 );
-				return (&backends[i]);
-			}
-#endif /* LDAP_ALLOW_NULL_SEARCH_BASE */
-
 			len = strlen( backends[i].be_suffix[j] );
 
 			if ( len > dnlen ) {
@@ -173,6 +161,19 @@ select_backend( char * dn )
                 }
         }
 
+#ifdef LDAP_ALLOW_NULL_SEARCH_BASE
+	/* Add greg@greg.rim.or.jp
+	 * It's quick hack for cheap client
+	 * Some browser offer a NULL base at ldap_search
+	 *
+	 * Should only be used as a last resort. -Kdz
+	 */
+	if(dnlen == 0) {
+		Debug( LDAP_DEBUG_TRACE,
+			"select_backend: use default backend\n", 0, 0, 0 );
+		return( &backends[0] );
+	}
+#endif /* LDAP_ALLOW_NULL_SEARCH_BASE */
 
 	return( NULL );
 }