From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Thu, 20 Feb 2025 11:45:42 +0000 (+0100)
Subject: [3.12] gh-130250: use support.swap_attr() in test and don't assume we're beginning... 
X-Git-Tag: v3.12.10~192
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=96a914ad7e95d21799bbd8bf275d593eaf5e92ba;p=thirdparty%2FPython%2Fcpython.git

[3.12] gh-130250: use support.swap_attr() in test and don't assume we're beginning with a clean system state (GH-130342) (#130345)

gh-130250: use support.swap_attr() in test and don't assume we're beginning with a clean system state (GH-130342)
(cherry picked from commit 048ee2d5ec761296ef67f5c59aee1f24408b12db)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
---

diff --git a/Lib/test/test_traceback.py b/Lib/test/test_traceback.py
index 0b8462dfd526..8300e511cf42 100644
--- a/Lib/test/test_traceback.py
+++ b/Lib/test/test_traceback.py
@@ -329,14 +329,10 @@ class TracebackCases(unittest.TestCase):
         self.assertEqual(output.getvalue(), "Exception: projector\n")
 
     def test_print_last(self):
-        self.assertIsNone(getattr(sys, "last_exc", None))
-        try:
-            sys.last_exc = ValueError(42)
+        with support.swap_attr(sys, 'last_exc', ValueError(42)):
             output = StringIO()
             traceback.print_last(file=output)
             self.assertEqual(output.getvalue(), "ValueError: 42\n")
-        finally:
-            sys.last_exc = None
 
     def test_format_exception_exc(self):
         e = Exception("projector")