From: Tom de Vries <tdevries@suse.de>
Date: Tue, 14 Oct 2025 09:51:50 +0000 (+0200)
Subject: [gdb/build] Fix buildbreaker on x86_64-freebsd in gdb/fbsd-nat.c
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=96d73418e905d53a97bbc0b05cb95698aefb8175;p=thirdparty%2Fbinutils-gdb.git

[gdb/build] Fix buildbreaker on x86_64-freebsd in gdb/fbsd-nat.c

Following commit 1ad8737b3c5 ("gdb: change inf_threads_iterator to yield
references"), we're running into a build breaker on x86_64-freebsd, in
gdb/fbsd-nat.c.

Fix this.

Tested by completing a build on x86_64-freebsd and running the TUI test-cases.
---

diff --git a/gdb/fbsd-nat.c b/gdb/fbsd-nat.c
index 3a4bd55a6e8..42f639d6d36 100644
--- a/gdb/fbsd-nat.c
+++ b/gdb/fbsd-nat.c
@@ -1207,16 +1207,16 @@ fbsd_nat_target::resume_one_process (ptid_t ptid, int step,
     {
       /* If ptid is a specific LWP, suspend all other LWPs in the
 	 process, otherwise resume all LWPs in the process..  */
-      if (!ptid.lwp_p() || tp->ptid.lwp () == ptid.lwp ())
+      if (!ptid.lwp_p () || tp.ptid.lwp () == ptid.lwp ())
 	{
-	  if (ptrace (PT_RESUME, tp->ptid.lwp (), NULL, 0) == -1)
+	  if (ptrace (PT_RESUME, tp.ptid.lwp (), NULL, 0) == -1)
 	    perror_with_name (("ptrace (PT_RESUME)"));
-	  low_prepare_to_resume (tp);
+	  low_prepare_to_resume (&tp);
 	  fbsd_inf->running_lwps++;
 	}
       else
 	{
-	  if (ptrace (PT_SUSPEND, tp->ptid.lwp (), NULL, 0) == -1)
+	  if (ptrace (PT_SUSPEND, tp.ptid.lwp (), NULL, 0) == -1)
 	    perror_with_name (("ptrace (PT_SUSPEND)"));
 	}
     }
@@ -1888,7 +1888,7 @@ fbsd_nat_target::detach_fork_children (inferior *inf)
   /* Detach any child processes associated with pending fork events in
      threads belonging to this process.  */
   for (thread_info &tp : inf->non_exited_threads ())
-    detach_fork_children (tp);
+    detach_fork_children (&tp);
 
   /* Unwind state associated with any pending events.  Reset
      fbsd_inf->resumed_lwps so that take_pending_event will harvest