From: Peter Krempa <pkrempa@redhat.com>
Date: Thu, 28 Jun 2012 21:42:50 +0000 (+0200)
Subject: network_conf: Don't free uninitialized pointers while parsing DNS SRV
X-Git-Tag: v0.9.13~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=96ebb4fe586512487f83b4696d20923315889796;p=thirdparty%2Flibvirt.git

network_conf: Don't free uninitialized pointers while parsing DNS SRV

If the user specified invalid protocol type in a network's SRV record
the error path ended up in freeing uninitialized pointers causing a
daemon crash.

*network_conf.c: virNetworkDNSSrvDefParseXML(): initialize local
                                                variables
---

diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index 60cd888a4e..515bc36edc 100644
--- a/src/conf/network_conf.c
+++ b/src/conf/network_conf.c
@@ -574,10 +574,10 @@ virNetworkDNSSrvDefParseXML(virNetworkDNSDefPtr def,
                             xmlNodePtr cur,
                             xmlXPathContextPtr ctxt)
 {
-    char *domain;
-    char *service;
-    char *protocol;
-    char *target;
+    char *domain = NULL;
+    char *service = NULL;
+    char *protocol = NULL;
+    char *target = NULL;
     int port;
     int priority;
     int weight;