From: Shlok Kulshreshtha Date: Tue, 14 Jul 2026 12:20:33 +0000 (+0530) Subject: t1100: move creation of expected output into setup test X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9719c290ee5926487caacc1ff059c043323ed183;p=thirdparty%2Fgit.git t1100: move creation of expected output into setup test The "expected" file is created at the top-level of the script, outside of any test. Code that runs outside of a test is not protected by the test harness: a failure there is not reported as a test failure and is easy to miss. Move the here-doc that creates "expected" into the existing setup test ("test preparation: write empty tree"), using a "<<-" here-doc so its body can be indented along with the rest of the test. Signed-off-by: Shlok Kulshreshtha Signed-off-by: Junio C Hamano --- diff --git a/t/t1100-commit-tree-options.sh b/t/t1100-commit-tree-options.sh index 9a639f946c..3e888909f5 100755 --- a/t/t1100-commit-tree-options.sh +++ b/t/t1100-commit-tree-options.sh @@ -14,15 +14,14 @@ Also make sure that command line parser understands the normal . ./test-lib.sh -cat >expected < 1117148400 +0000 -committer Committer Name 1117150200 +0000 - -comment text -EOF - test_expect_success 'test preparation: write empty tree' ' + cat >expected <<-EOF && + tree $EMPTY_TREE + author Author Name 1117148400 +0000 + committer Committer Name 1117150200 +0000 + + comment text + EOF git write-tree >treeid '