From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Tue, 8 Feb 2022 23:06:59 +0000 (-0500)
Subject: Don't crash if the user explicitly specifies a vector algorithm that isn't milenage
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=97295cae422afb27cfee7532c7293e800a2751eb;p=thirdparty%2Ffreeradius-server.git

Don't crash if the user explicitly specifies a vector algorithm that isn't milenage
---

diff --git a/src/lib/eap_aka_sim/vector.c b/src/lib/eap_aka_sim/vector.c
index 3d899fd9d19..c8d3c033779 100644
--- a/src/lib/eap_aka_sim/vector.c
+++ b/src/lib/eap_aka_sim/vector.c
@@ -80,7 +80,7 @@ static int vector_gsm_from_ki(request_t *request, fr_pair_list_t *vps, int idx,
 {
 	fr_pair_t	*ki_vp, *version_vp;
 	uint8_t		opc_buff[MILENAGE_OPC_SIZE];
-	uint8_t	const	*opc_p;
+	uint8_t	const	*opc_p = NULL;
 	uint32_t	version;
 	unsigned int	i;
 
@@ -168,7 +168,7 @@ static int vector_gsm_from_ki(request_t *request, fr_pair_list_t *vps, int idx,
 	 *	Store for completeness...
 	 */
 	memcpy(keys->auc.ki, ki_vp->vp_octets, sizeof(keys->auc.ki));
-	memcpy(keys->auc.opc, opc_p, sizeof(keys->auc.opc));
+	if (opc_p) memcpy(keys->auc.opc, opc_p, sizeof(keys->auc.opc));
 	keys->vector_src = AKA_SIM_VECTOR_SRC_KI;
 
 	return 0;