From: Johannes Naab <naab@net.in.tum.de>
Date: Thu, 4 Sep 2014 17:49:36 +0000 (+0200)
Subject: Fix memory leak in ldns_pkt_rr_list_by_name()
X-Git-Tag: release-1.7.0-rc1~149
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9737e52f63b2b23ad8b4d220deecb3bc35a58037;p=thirdparty%2Fldns.git

Fix memory leak in ldns_pkt_rr_list_by_name()

The intermediate copy for section selection wasn't freed.
---

diff --git a/packet.c b/packet.c
index 7c427831..54594dde 100644
--- a/packet.c
+++ b/packet.c
@@ -273,9 +273,15 @@ ldns_pkt_rr_list_by_name(ldns_pkt *packet,
 			if (ret == NULL) {
 				ret = ldns_rr_list_new();
 			}
-			ldns_rr_list_push_rr(ret, ldns_rr_list_rr(rrs, i));
+			ldns_rr_list_push_rr(ret,
+					     ldns_rr_clone(
+						ldns_rr_list_rr(rrs, i))
+					    );
 		}
 	}
+
+	ldns_rr_list_deep_free(rrs);
+
 	return ret;
 }