From: Victor Julien <victor@inliniac.net>
Date: Thu, 17 Oct 2013 15:41:03 +0000 (+0200)
Subject: Minor pppoe cleanup
X-Git-Tag: suricata-2.0beta2~211
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=974e86e45059f1c0ead9e1e82cfcaf68bd6053a9;p=thirdparty%2Fsuricata.git

Minor pppoe cleanup

cppcheck said:
[decode-pppoe.c:58] -> [decode-pppoe.c:60]: (performance, inconclusive) Variable 'pppoedh' is reassigned a value before the old one has been used if variable is no semaphore variable.
---

diff --git a/src/decode-pppoe.c b/src/decode-pppoe.c
index 7f49046b5d..83e2b09623 100644
--- a/src/decode-pppoe.c
+++ b/src/decode-pppoe.c
@@ -55,7 +55,6 @@ void DecodePPPOEDiscovery(ThreadVars *tv, DecodeThreadVars *dtv, Packet *p, uint
         ENGINE_SET_EVENT(p, PPPOE_PKT_TOO_SMALL);
         return;
     }
-    p->pppoedh = NULL;
 
     p->pppoedh = (PPPOEDiscoveryHdr *)pkt;
     if (p->pppoedh == NULL)