From: Colin Vidal <colin@isc.org>
Date: Wed, 11 Jun 2025 13:45:52 +0000 (+0200)
Subject: fix watchlog.py doctest
X-Git-Tag: v9.21.11~40^2~11
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9778068253e9147f7b33d47c7f0ef221cee6b9f9;p=thirdparty%2Fbind9.git

fix watchlog.py doctest

Fix some broken doctest in watchlog.py (no semantic error, but API
slightly changed and broke some output messags). Also add a test for a
missing failure case.
---

diff --git a/bin/tests/system/isctest/log/watchlog.py b/bin/tests/system/isctest/log/watchlog.py
index ffa75e156df..3d35df09e9f 100644
--- a/bin/tests/system/isctest/log/watchlog.py
+++ b/bin/tests/system/isctest/log/watchlog.py
@@ -76,20 +76,26 @@ class WatchLog(abc.ABC):
         ...     print("Just print something without waiting for a log line")
         Traceback (most recent call last):
           ...
-        Exception: wait_for_*() was not called
+        isctest.log.watchlog.WatchLogException: wait_for_*() was not called
 
         >>> with WatchLogFromHere("/dev/null") as watcher:
         ...     try:
-        ...         watcher.wait_for_line("foo", timeout=0)
+        ...         watcher.wait_for_line("foo", timeout=0.1)
         ...     except TimeoutError:
         ...         pass
         ...     try:
-        ...         watcher.wait_for_lines({"bar": 42}, timeout=0)
+        ...         watcher.wait_for_lines({"bar": 42}, timeout=0.1)
         ...     except TimeoutError:
         ...         pass
         Traceback (most recent call last):
           ...
-        Exception: wait_for_*() was already called
+        isctest.log.watchlog.WatchLogException: wait_for_*() was already called
+
+        >>> with WatchLogFromHere("/dev/null") as watcher:
+        ...     watcher.wait_for_line("foo", timeout=0)
+        Traceback (most recent call last):
+          ...
+        AssertionError: Do not use this class unless you want to WAIT for something.
         """
         self._fd = None  # type: Optional[TextIO]
         self._path = path