From: John (J5) Palmieri <johnp@redhat.com>
Date: Tue, 15 Jan 2008 20:30:19 +0000 (-0500)
Subject: make sure to call va_end if we hit an OOM error inside va_start (FDO Bug #12846)
X-Git-Tag: dbus-1.1.3~12
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=97872bf72ff327855e2e86a4760348cd2ca03b9e;p=thirdparty%2Fdbus.git

make sure to call va_end if we hit an OOM error inside va_start (FDO Bug #12846)

2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

	* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

	* dbus/dbus-errors.c (dbus_set_error): make sure to call va_end if we
	hit an OOM error inside va_start (FDO Bug #12846)
---

diff --git a/ChangeLog b/ChangeLog
index c3d79d1b1..84faa733f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2008-01-15  John (J5) Palmieri  <johnp@redhat.com>
+	
+	* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>
+
+	* dbus/dbus-errors.c (dbus_set_error): make sure to call va_end if we
+	hit an OOM error inside va_start (FDO Bug #12846)
+
 2008-01-15  John (J5) Palmieri  <johnp@redhat.com>
 	
 	* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>
diff --git a/dbus/dbus-errors.c b/dbus/dbus-errors.c
index 9629c682d..6d14ff7af 100644
--- a/dbus/dbus-errors.c
+++ b/dbus/dbus-errors.c
@@ -384,6 +384,7 @@ dbus_set_error (DBusError  *error,
       if (!_dbus_string_append_printf_valist (&str, format, args))
         {
           _dbus_string_free (&str);
+          va_end (args);
           goto nomem;
         }
       va_end (args);